-
Notifications
You must be signed in to change notification settings - Fork 834
Cortex-M backend: Add quantized s8 pad operator via CMSIS-NN #17320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add cortex_m::pad that delegates to arm_pad_s8. The operator takes pre_pad/post_pad arrays in CMSIS-NN 4D format — the AoT fusion pass converts from PyTorch's constant_pad_nd padding format, validates rank/padding constraints, and quantizes the float pad value to int8. Pad is a shared-qspec op (input/output share quantization parameters). Co-authored-by: Claude <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17320
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New FailuresAs of commit 9285d58 with merge base f4ef59f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
AdrianLundell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, but overall really nice job!
Fix copyright headers to use Meta-only format, tighten qtol from 1 to 0 (pad is exact), and use quantize_val helper instead of inline clamping. Authored with Claude.
|
Failures unrelated. |
Summary
Add cortex_m::pad that delegates to arm_pad_s8. The operator takes pre_pad/post_pad arrays in CMSIS-NN 4D format — the AoT fusion pass converts from PyTorch's constant_pad_nd padding format, validates rank/padding constraints, and quantizes the float pad value to int8.
Pad is a shared-qspec op (input/output share quantization parameters).
Fixes #16111
Test plan