-
Notifications
You must be signed in to change notification settings - Fork 834
Qualcomm AI Engine Direct - Support SLC allocator feature #17302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Qualcomm AI Engine Direct - Support SLC allocator feature #17302
Conversation
Summary: - Support SLC allocator feature setting - Support spill-fill buffer for hybrid mode
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17302
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit a880a42 with merge base efe4f0c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Look good to me. |
|
@pytorchbot label "release notes: qualcomm" |
| /// Allows user to enable the usage of the System Level Cache Allocator for a given graph. | ||
| /// It will help the by reducing overall bandwith on the use case. | ||
| /// The feature is only supported by specific SOCs. | ||
| use_slc_allocator:bool; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we're adding a new feature, can we update the read me regarding how to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly a bit more explanation on System Level Cache Allocator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a new feature. Users just need to set use_slc_allocator=True in compile_spec to enable it.
https://github.com/pytorch/executorch/pull/17302/changes#diff-0439f6a7c1a3a3cfb222cd6409b6754f17a1ce782dd231de1d12bbf957d588f7R1000
System Level Cache Allocator is a shared cache at the system level of a SoC, serving as the last caching layer before external DDR memory. Its primary purpose is to optimize memory bandwidth, thereby potentially improving performance and reducing power consumption. However, it is model-dependent, so it is not guaranteed to be effective in all cases.
Summary:
Test Plan: