Skip to content

[mypyc] fix: Final load in unreachable branches #20617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BobTheBuidler wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[mypyc] fix: Final load in unreachable branches #20617

BobTheBuidler wants to merge 10 commits into from
+45 −8

Conversation

@BobTheBuidler
Copy link
Contributor

@BobTheBuidler BobTheBuidler commented Jan 18, 2026 •
edited
Loading

  • avoid crashing when loading Final values in unreachable branches by falling back to the declared type
  • add an irbuild-unreachable regression test for Final name loads

Fixes mypyc/mypyc#1180

@BobTheBuidler BobTheBuidler changed the title Pr 19672 [mypyc] fix: Final load in unreachable branches Jan 18, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@BobTheBuidler BobTheBuidler marked this pull request as ready for review January 18, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash (KeyError: NameExpr) when Final constant returned under if x is None for non‑Optional param

1 participant

@BobTheBuidler