Skip to content

test_filecmp: Add tests for filecmp.cmp cache hit and overflow clearing - #159051

Closed
Bolotnyj wants to merge 2 commits into
python:mainfrom
Bolotnyj:hunt-uncovered-tests
Closed

Bolotnyj wants to merge 2 commits into
python:mainfrom
Bolotnyj:hunt-uncovered-tests

Conversation

@Bolotnyj

@Bolotnyj Bolotnyj commented Oct 9, 2026

Copy link
Copy Markdown

Description

Added unit tests to cover the cache hit and cache overflow clearing logic inside the filecmp.cmp() function.

Locally verified that tests successfully cover previously missing branch conditions.

@python-cla-bot

python-cla-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Oct 9, 2026
@bedevere-app

bedevere-app Bot commented Oct 9, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Bolotnyj
Bolotnyj force-pushed the hunt-uncovered-tests branch from 0dcf6e1 to e85d8a8 Compare October 9, 2026 09:40
@bedevere-app

bedevere-app Bot commented Oct 9, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Oct 9, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Bolotnyj Bolotnyj closed this Oct 9, 2026
@Bolotnyj
Bolotnyj deleted the hunt-uncovered-tests branch October 9, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant