GH-144179: Add value recording to JIT tracing front-end#144303
Merged
markshannon merged 5 commits intopython:mainfrom Feb 2, 2026
Merged
GH-144179: Add value recording to JIT tracing front-end#144303markshannon merged 5 commits intopython:mainfrom
markshannon merged 5 commits intopython:mainfrom
Conversation
markshannon
requested review from
AA-Turner,
Fidget-Spinner,
emmatyping,
erlend-aasland,
savannahostrowski and
tomasr8
as code owners
markshannon
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 515a570 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144303%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
Fidget-Spinner
approved these changes
Jan 29, 2026
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Just one nit, feel free to merge after.
| @@ -0,0 +1,115 @@ | |||
| // This file is generated by Tools/cases_generator/record_function_generator.py | |||
Member
There was a problem hiding this comment.
Should this file be mark as autogenerated in the github CI?
Aniketsy
pushed a commit
to Aniketsy/cpython
that referenced
this pull request
Feb 3, 2026
| assert(strncmp(_PyOpcode_uop_name[buffer[pc].opcode], _PyOpcode_uop_name[opcode], strlen(_PyOpcode_uop_name[opcode])) == 0); | ||
| } | ||
| else if (_PyUop_Flags[opcode] & HAS_RECORDS_VALUE_FLAG) { | ||
| Py_XDECREF((PyObject *)(uintptr_t)buffer[pc].operand0); |
Member
There was a problem hiding this comment.
We should move this to the finalize tracing path. Otherwise, this doesn't handle the error paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step toward cleaning up front-end tracking of objects.
This adds recording, but doesn't use for optimization, to keep the PRs to manageable sizes.
Demonstrates that it works, doesn't leak memory.
Also removes
IP_OFFSET_OF, as that broke when adding new uops.