gh-143928: Remove outdated comparison between pickle and marshal regarding recursion #144025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
Yashp002
changed the title
Yashp002
changed the title
Yashp002
changed the title
Yashp002
changed the title
Contributor
Author
|
@picnixz Would this PR be satisfactory? |
picnixz
reviewed
Jan 25, 2026
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Yes, but please check that there is no such comparison in marshal.rst as well (maybe we have this kind of mention in marshal.rst, idk)
Contributor
Author
|
@picnixz The only 4 mentions of the pickle module in marshal.rst seem to be about RPC calls and where pickle can be used. Nothing that suggests marshal doesn't support recursion or object sharing. So i think this is fine |
picnixz
approved these changes
Jan 26, 2026
vstinner
added
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 26, 2026
…l regarding recursion (pythonGH-144025) (cherry picked from commit 923d9d2) Co-authored-by: Yashraj <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 26, 2026
…l regarding recursion (pythonGH-144025) (cherry picked from commit 923d9d2) Co-authored-by: Yashraj <[email protected]>
|
GH-144246 is a backport of this pull request to the 3.14 branch. |
|
GH-144247 is a backport of this pull request to the 3.13 branch. |
Member
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an outdated section in the
picklemodule documentation that incorrectly statesmarshaldoes not support object sharing or recursive objects.As confirmed by core developers,
marshal(protocol version 3+) supports both shared references and recursion, making the previous claim inaccurate. This change simply removes the incorrect statement without adding further comparisons, as requested.Fixes #143298
📚 Documentation preview 📚: https://cpython-previews--144025.org.readthedocs.build/