Skip to content

gh-143959 make test_sys import _datetime inside the test #144003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youknowone wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

gh-143959 make test_sys import _datetime inside the test #144003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/test/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import builtins
import codecs
import _datetime
import gc
import io
import locale
Expand Down Expand Up @@ -1566,6 +1565,8 @@ def test_default(self):
self.assertEqual(sys.getsizeof(True, -1), size('') + self.longdigit)

def test_objecttypes(self):
import _datetime
Copy link
Member

@serhiy-storchaka serhiy-storchaka Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to import it just before it is used, like collections.

And since it is optional, skip the corresponding test if the import fails.


# check all types defined in Objects/
calcsize = struct.calcsize
size = test.support.calcobjsize
Expand Down
Loading