Skip to content

gh-143930: Reject leading dashes in webbrowser URLs #143931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sethmlarson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-143930: Reject leading dashes in webbrowser URLs #143931

sethmlarson wants to merge 1 commit into from
+19 −0

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Jan 16, 2026 •
edited by bedevere-app bot
Loading

@sethmlarson sethmlarson requested a review from gpshead January 16, 2026 18:06
@sethmlarson sethmlarson added type-security A security issue needs backport to 3.10 only security fixes stdlib Standard Library Python modules in the Lib/ directory needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 16, 2026
@bedevere-app bedevere-app bot mentioned this pull request Jan 16, 2026
Open
@Yhg1s
Copy link
Member

Yhg1s commented Jan 19, 2026

What about / or other common option prefixes?

@sethmlarson
Copy link
Contributor Author

sethmlarson commented Jan 19, 2026

@Yhg1s I'm concerned that there are use-cases for calling webbrowser.open() on paths, so we'd have to be more cautious in this case. Another option I suggested was to percent-encode spaces?

@gpshead
Copy link
Member

gpshead commented Jan 24, 2026

on windows a '/' prefix is typically a command line flag - does it actually work as an absolute current drive path on edge/chrome/firefox? to be a url for that it really should be "file://"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

awaiting merge needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes stdlib Standard Library Python modules in the Lib/ directory type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethmlarson @Yhg1s @gpshead