Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Can we squash the commits please? |
jlarkin09
force-pushed
the
codex/1206-build-sdist-pep517
branch
from
October 20, 2026 16:00
df6a96f to
c01db95
Compare
smoparth
requested changes
Oct 21, 2026
jlarkin09
force-pushed
the
codex/1206-build-sdist-pep517
branch
from
October 22, 2026 14:36
c01db95 to
3a5e448
Compare
smoparth
requested changes
Oct 22, 2026
1 task done
jlarkin09
force-pushed
the
codex/1206-build-sdist-pep517
branch
from
October 22, 2026 20:41
3a5e448 to
9008926
Compare
smoparth
reviewed
Oct 22, 2026
Honor configured PEP 517 and tarball strategies, warning when an installed build hook is ignored. Require resolvers to declare their strategy and hook-sdist to choose it explicitly. Keep build overrides for legacy settings. Co-Authored-By: Codex <codex@openai.com> Closes: python-wheel-build#1206 Related: python-wheel-build#1256 Signed-off-by: Justin Larkin <jlarkin@redhat.com>
jlarkin09
force-pushed
the
codex/1206-build-sdist-pep517
branch
from
October 23, 2026 13:29
9008926 to
ff5216c
Compare
smoparth
approved these changes
Oct 23, 2026
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
rd4398
merged commit Oct 23, 2026
f1ee225
into
python-wheel-build:new-resolver-config
37 of 38 checks passed
smoparth
added a commit
to smoparth/fromager
that referenced
this pull request
Oct 23, 2026
Merge new-resolver-config after python-wheel-build#1385 and keep checkout preparation compatible with the sdist strategy. Reject nested submodule changes and document the public helper, cleanup behavior, and required checkout layout. Co-Authored-By: Codex <codex@openai.com> Signed-off-by: Shanmukh Pawan <smoparth@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build sdists using the configured resolver strategy so Git checkouts can use PEP 517 to generate proper version metadata.
hook-sdistrequires an explicitbuild_sdistsetting. Configured PEP 517 and tarball builds ignore installedbuild_sdistoverrides with a warning; legacy settings continue to use overrides.Validation: 176 focused tests, Ruff, mypy, and a real Stevedore tarball build confirming that the installed override is skipped and the warning is visible.
Closes: #1206