Fixed default value for traceback_show_locals.#1655
Merged
kmvanbrunt merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
- Coverage 99.51% 99.49% -0.03%
==========================================
Files 21 21
Lines 4733 4737 +4
==========================================
+ Hits 4710 4713 +3
- Misses 23 24 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
approved these changes
Apr 29, 2026
| # If setting is not present, then return its default value. | ||
| traceback_sig = inspect.signature(Traceback.__init__) | ||
| show_locals = traceback_sig.parameters["show_locals"].default | ||
| return cast(bool, show_locals) |
Member
There was a problem hiding this comment.
Is it worth saying anything in the CHANGELOG.md about this fix?
Member
Author
There was a problem hiding this comment.
No, I only added this setting in beta 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.