Keep removing Python pre-3.9 code#218
Draft
DimitriPapadopoulos wants to merge 3 commits into
Draft
Conversation
DimitriPapadopoulos
force-pushed
the
UP036
branch
3 times, most recently
from
December 11, 2025 21:03
e01b11a to
527949f
Compare
DimitriPapadopoulos
force-pushed
the
UP036
branch
from
January 16, 2026 17:08
527949f to
36da74b
Compare
DimitriPapadopoulos
force-pushed
the
UP036
branch
2 times, most recently
from
March 25, 2026 15:10
1f2f72b to
aaa88ae
Compare
mattip
reviewed
Mar 26, 2026
mattip
left a comment
mattip
left a comment
Contributor
There was a problem hiding this comment.
I actually read the whole thing and only had two nits
| import __builtin__ | ||
| except ImportError: | ||
| import builtins as __builtin__ | ||
| import builtins |
Contributor
There was a problem hiding this comment.
I think this can be removed?
| try: | ||
| from _thread import allocate_lock | ||
| except ImportError: | ||
| from _dummy_thread import allocate_lock |
Contributor
There was a problem hiding this comment.
When might this fail? I think _thread is required for Python now.
Contributor
Author
There was a problem hiding this comment.
Indeed _threadhas always been part of Python 3.
DimitriPapadopoulos
force-pushed
the
UP036
branch
from
March 27, 2026 16:33
aaa88ae to
d7797c5
Compare
DimitriPapadopoulos
marked this pull request as ready for review
March 27, 2026 16:33
DimitriPapadopoulos
force-pushed
the
UP036
branch
3 times, most recently
from
March 30, 2026 22:37
2b0bbe5 to
b594ec7
Compare
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
UP036
branch
3 times, most recently
from
March 30, 2026 22:40
190b007 to
95033ea
Compare
DimitriPapadopoulos
marked this pull request as draft
March 30, 2026 22:40
DimitriPapadopoulos
force-pushed
the
UP036
branch
from
March 30, 2026 22:42
95033ea to
fe23206
Compare
|
This may need to be rebased and retested. |
Contributor
Author
|
Yes, this is still a work in progress. Some changes break CI. I need to apply smaller change sets gradually — after rebasing. |
DimitriPapadopoulos
force-pushed
the
UP036
branch
2 times, most recently
from
April 29, 2026 18:05
2240429 to
938ddcd
Compare
DimitriPapadopoulos
marked this pull request as ready for review
July 19, 2026 19:56
DimitriPapadopoulos
force-pushed
the
UP036
branch
from
July 19, 2026 20:33
938ddcd to
32e1e17
Compare
DimitriPapadopoulos
marked this pull request as draft
July 19, 2026 20:33
DimitriPapadopoulos
force-pushed
the
UP036
branch
from
July 19, 2026 20:35
32e1e17 to
b559cfe
Compare
These are automatic fixes using: * `--select UP036 --fix --unsafe-fixes`
DimitriPapadopoulos
force-pushed
the
UP036
branch
from
July 19, 2026 21:42
8c5ba8e to
548326f
Compare
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
UP036
branch
from
July 20, 2026 07:21
548326f to
ee3070f
Compare
These are manual fixes
DimitriPapadopoulos
force-pushed
the
UP036
branch
from
July 20, 2026 07:57
ee3070f to
2de1e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #124 and #214.
Apply rule UP036, it implies lots of manual changes and requires extra care.
Needs #214 to be applied first.