Repository navigation
Split execute so it no longer needs noqa: C901 - #3082
Merged
janiversen merged 1 commit intoNov 4, 2026
Merged
Conversation
The reconnect check moves to _connect_if_needed, and the handling of a request that got no response after its retries moves to _no_response, which sync_execute now uses too.
Collaborator
|
Thanks, nice split. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #3076, this makes the
# noqa: C901onTransactionManager.execute()unnecessary._connect_if_needed()._no_response().sync_execute()uses it too, so the two methods share that code instead of mirroring it.Behaviour is unchanged. With
ruff check --select C901 --ignore-noqa,execute()goes from 13 to 9 andsync_execute()from 9 to 7.Validation
pytest test/transaction: 54 passed on Python 3.10 and 3.14 (macOS), with 100% line and branch coverage ofpymodbus/transactionandtest/transaction.pytest test/client: 241 passed. The 3test_client_tls_connectcases fail the same way on unmodifieddevhere (local TLS setup).ruff check,ruff format --check,codespell,zuban checkandpylint(10.00/10) on the touched file are clean.AI disclosure: written with an AI coding agent and tested as described above.