Skip to content

[FIX] Tick-formatting for spharpy.plot.scatter - #319

Merged
mberz merged 8 commits into
mainfrom
bugfix/scatter-plot
Jul 6, 2026
Merged

[FIX] Tick-formatting for spharpy.plot.scatter#319
mberz merged 8 commits into
mainfrom
bugfix/scatter-plot

Conversation

@hoyer-a

@hoyer-a hoyer-a commented Apr 10, 2026

Copy link
Copy Markdown
Member

Which issue(s) are closed by this pull request?

Closes #313

  • make number of ticks adaptive
  • use default of 10 bins for longest axis (matplotlib default), fall back to 1 bin if axis range is too small
  • get number of ticks relative to tick spacing on longest axis
  • create baseline plots

@hoyer-a
hoyer-a force-pushed the bugfix/scatter-plot branch from 7a8cd21 to b0d4fcc Compare April 10, 2026 11:07
@hoyer-a hoyer-a added this to the v1.0.1 milestone Apr 10, 2026
@hoyer-a hoyer-a added bug Something isn't working plot labels Apr 10, 2026
@hoyer-a
hoyer-a requested review from a team, ahms5, f-brinkmann, mberz, sikersten and tluebeck April 10, 2026 11:11
@hoyer-a hoyer-a moved this from Backlog to Require review in Weekly Planning Apr 10, 2026

@ahms5 ahms5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care. Have you recreate the baseline plots? I bet, sth would change there. I would also recomment to add a test, so that this woulnt happen again.

@hoyer-a
hoyer-a marked this pull request as draft April 13, 2026 13:49
@hoyer-a hoyer-a moved this from Require review to Implementation in progress in Weekly Planning Apr 13, 2026
@hoyer-a
hoyer-a force-pushed the bugfix/scatter-plot branch from b0d4fcc to aefa613 Compare April 14, 2026 12:16
@hoyer-a hoyer-a changed the title [Plots] Equal axis aspect ratio for spharpy.plot.scatter [DRAFT] Equal axis aspect ratio for spharpy.plot.scatter Apr 14, 2026
@hoyer-a hoyer-a changed the title [DRAFT] Equal axis aspect ratio for spharpy.plot.scatter [DRAFT] Tick-formatting for spharpy.plot.scatter Apr 20, 2026
@mberz

mberz commented May 5, 2026

Copy link
Copy Markdown
Member

Hey @hoyer-a, I was wondering if there's any progress on this? If no I think I'd prepare the next bug release without this PR included. I feel that the bugfixes currently waiting to be released are more urgent than this one, so don't worry if you don't have the bandwidth to finalize this one at the moment.

@hoyer-a

hoyer-a commented May 5, 2026

Copy link
Copy Markdown
Member Author

Not really, i made some progress with the tick locators and formatting but it's still no good solution.
I want to get something ready before friday, but if the bugfixes are really urgent i think this one can wait.

@hoyer-a
hoyer-a marked this pull request as ready for review May 22, 2026 08:17
@hoyer-a hoyer-a moved this from Implementation in progress to Require review in Weekly Planning May 22, 2026
@hoyer-a
hoyer-a requested a review from ahms5 May 22, 2026 08:18
@hoyer-a hoyer-a changed the title [DRAFT] Tick-formatting for spharpy.plot.scatter [Plots] Tick-formatting for spharpy.plot.scatter May 22, 2026
@mberz mberz moved this from Require review to Agenda in Weekly Planning Jul 3, 2026
@mberz mberz changed the title [Plots] Tick-formatting for spharpy.plot.scatter [FIX] Tick-formatting for spharpy.plot.scatter Jul 3, 2026
@mberz mberz moved this from Agenda to Implementation in progress in Weekly Planning Jul 3, 2026
@hoyer-a
hoyer-a force-pushed the bugfix/scatter-plot branch from 828e9c9 to 12b6207 Compare July 3, 2026 14:13
@hoyer-a hoyer-a moved this from Implementation in progress to Require review in Weekly Planning Jul 3, 2026
@hoyer-a
hoyer-a force-pushed the bugfix/scatter-plot branch from fa49f0a to e1a6068 Compare July 3, 2026 14:17
@hoyer-a
hoyer-a requested a review from a team July 3, 2026 14:17

@mberz mberz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only have a tiny nitpick on the code to make it more readable.

Can you please add a history entry?

Comment thread spharpy/plot/spatial.py Outdated
@hoyer-a
hoyer-a force-pushed the bugfix/scatter-plot branch from e409683 to c3df7ef Compare July 4, 2026 13:48
@hoyer-a
hoyer-a requested a review from mberz July 4, 2026 14:06

@mberz mberz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mberz
mberz merged commit 8ee6f89 into main Jul 6, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Require review to Done in Weekly Planning Jul 6, 2026
@mberz
mberz deleted the bugfix/scatter-plot branch July 6, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working plot

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] spharpy.plot.scatter axes collapse when plotting subsets of samplings

3 participants