as/transform: near-miss marker warning (F1) + asc dep floor (F2) - #28
Merged
Conversation
Two follow-ups from the #23 review. F1 — a decorator one edit away from a marker (@veiw, @mutatng, @payble) was silently left on the AST and the function it meant to constrain compiled unchecked — the one silent-miss that most undermines the 'checked against otigen.toml' promise. partitionDecorators now takes an optional warn callback and, for a non-marker decorator within one edit (transposition included) of a real marker, tells the author it is being left unchecked and what they likely meant. Purely diagnostic — the wasm is unaffected, and a real marker or an asc built-in (@inline) never trips it. Covered by two collectIntents tests. F2 — the asc dep floor (^0.27.0 / peer >=0.27.0) sat below the range the transform actually enforces (>=0.27.30). A clean install resolving 0.27.0-0.27.29 would stand the transform down while the tests expect it to run. Both the devDep and the peer range now start at 0.27.30 and cap below 0.29.0, matching SUPPORTED_ASC_RANGE. F3 (unconventional manifest shapes) is left as-is: the parser reads only [functions.NAME] headers by design — a tested choice — it is fail-closed with an actionable error, and otigen only ever emits headers. Suite: 31/31 on asc 0.27.37 and 0.28.20.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the #23 review (tracked in the now-closed #27).
F1 — a decorator one edit from a marker (
@veiw,@mutatng,@payble) was silently left on the AST and its function compiled unchecked.partitionDecoratorsnow takes an optionalwarnand flags a non-marker within one edit (transposition-aware, so@veiwis caught) of a real marker. Diagnostic only — wasm unaffected; real markers and@inlinenever trip it. +2 tests.F2 — the asc dep floor (
^0.27.0/ peer>=0.27.0) sat below the enforced floor0.27.30; a clean install resolving <0.27.30 would stand the transform down while tests expect it running. Both now>=0.27.30 <0.29.0, matchingSUPPORTED_ASC_RANGE.F3 left as-is — by design (parser reads only
[functions.NAME]headers, a tested choice; fail-closed, otigen only emits headers).Suite: 31/31 on asc 0.27.37 and 0.28.20.