go: full-module CI gate + fix stale probe (Phase 6 hardening) - #22
Merged
Conversation
Two coupled fixes that harden the Go host module for release: - The import-purity probe still destructured Instantiate() into 2 values, but the factory API returns 3 (Address, []byte, int32) — so the probe failed to tinygo-build and the root-package test suite was red. Updated the probe to the current signature. - CI only ran `go test ./child`, never the root package, so that red test (and the borsh conformance/parity + u128 suites) never gated a release — which is how a broken probe shipped in alpha.12. The Go job now runs gofmt + `go vet ./...` + `go test ./...` over the whole module (tinygo is already installed in that job, so the import-purity test runs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the Go host module before its next release.
./child; now gates the whole module (gofmt + go vet ./... + go test ./...). This is why alpha.12 shipped with a red root test.Local gate green: gofmt clean, vet clean,
go test ./...passes.