Skip to content

docs: point to engines.node for the Node requirement - #80

Merged
altaywtf merged 1 commit into
mainfrom
docs/toolchain-pointers
Sep 23, 2026
Merged

altaywtf merged 1 commit into
mainfrom
docs/toolchain-pointers

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Problem

The README restated the Node range (>=24.19.0) that engines.node in package.json already declares, so every Node bump needed a matching doc edit.

Solution

Point the install note at engines.node in package.json.

Proof

pnpm run check passes; the pre-push verify gate passed.

Copilot AI lite review requested due to automatic review settings September 23, 2026 16:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T16:02:22.510524Z d56416d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is documentation-only and correctly points to the existing canonical Node requirement in package.json.

Review effort: Lite
Findings: None

What changed in this PR

This PR reduces documentation drift by removing the hard-coded Node version from the README and instead pointing readers to the canonical engines.node requirement already defined in package.json.

Changes:

  • Update the README install note to reference package.json’s engines.node field as the source of truth for the required Node version.
File Description
README.md Replaces the duplicated Node version requirement with a reference to package.json’s engines.node.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@altaywtf
altaywtf merged commit 132dc73 into main Sep 23, 2026
7 checks passed
@altaywtf
altaywtf deleted the docs/toolchain-pointers branch September 23, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants