Track locker-side PUSH reversals and block untracked recovery - #24
Open
Zartaj0 wants to merge 4 commits into
Open
Track locker-side PUSH reversals and block untracked recovery#24Zartaj0 wants to merge 4 commits into
Zartaj0 wants to merge 4 commits into
Conversation
- Add lockedBySenderRecipientEpoch to track net claimable balance per sender/recipient/epoch so refunds can be validated against real deposits - Add refundLockedFunds (onlyOwner) to return PUSH to original sender and emit Unlocked event, decrementing the tracked balance - Block recoverFunds(PUSH_TOKEN, ...) to prevent invisible PUSH outflow that would silently break the off-chain balance-delta validation - Add refundsEnabled flag at initialize time so refund capability is explicit and per-instance - Update event builder to fetch and net Unlocked events against Locked events by sender/recipient/epoch before producing the claims file
- Replace single-locker config with fixed preMigration/migration topology - Pre-migration source always processes Locked - Unlocked (refund netting) - Migration source always processes Locked only - resolveLockerSources validates both addresses are configured and distinct, preventing silent double-count if the same address is pasted into both slots - mergeClaims combines per-source claim groups by recipient+epoch so both lockers contribute to a single merged root without duplicate leaves - Add TwoLockerApproach tests documenting the double-claim and orphaned-leaf failure modes that make the operational sequencing rules load-bearing
Zartaj0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the locker-side accounting gap where PUSH could leave
MigrationLockerwithout being reflected in the off-chain claim builder.Changes
sender + recipient + epochUnlocked(sender, recipient, amount, epoch)refundLockedFunds(...)to return PUSH to the original sender through an explicit tracked pathrecoverFunds(PUSH_TOKEN, ...)Locked - UnlockedrefundsEnabledScope
MigrationRelease