Repository navigation
Telemetry name gen - #143
Merged
Merged
Conversation
SampleApp.Shared now owns both the telemetry and the behaviour that emits it: WeatherForecastValidator uses IWeatherForecastTelemetry, and the library registers its own services via AddWeatherForecastValidation(). WeatherService routes forecasts through the validator, so the shared library's activity source and meter are genuinely emitted rather than only generated. Both names default to the assembly name, so SampleApp.Shared is easy to spot in each host's aggregated TelemetryNames, which previously carried the less obvious sample-shared-library source name and no meter at all.
CA1515 was suppressed through NoWarn, which Purview.BuildSdk 1.0.3 rejects as a policy violation (PRSGD0008), so the solution could not build without DisablePurviewStylePolicyValidation. The console app needs no public types, so IWeatherService, WeatherForecast and IWeatherServiceTelemetry are now internal and the suppression is gone. Five of the remaining suppressions no longer fire (CA1303, CA1812, CA2007, CA2201, CS1574) and two are now fixed rather than silenced: Summary is initialised (CS8618) and activities are modelled as Activity? (TSG3022), which also clears the CS8604s that surfaced. Three pre-existing PDS0003 warnings in Program.cs are fixed too. The solution now builds with no warnings and no errors, leaving CA1031 and CA5394 as the only suppressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.