Repository navigation
build: take Purview.Build 0.5.3 - #28
Merged
Merged
Conversation
Picks up the fix that makes RequiredCompilerFlags configurable: earlier versions forced the compiler-flag check on because binding an empty JSON array contributes no configuration keys, so the tool's non-empty code default could never be overridden. This repository declares "RequiredCompilerFlags": ["optimization=release"] explicitly, so the check it has always run under is preserved. Verified with just pipeline-pack-validate against 0.5.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps this repository''s own pinned
Purview.Buildlocal tool from 0.5.2 to 0.5.3, now that #27 is merged and 0.5.3 is published.0.5.3 is the release that makes
RequiredCompilerFlagsconfigurable: earlier versions forced the compiler-flag check on, because binding an empty JSON array contributes no configuration keys and so never overwrote the tool''s non-empty code default.This repository already declares
"RequiredCompilerFlags": ["optimization=release"]in.config/purview-build.json, so the check it has always run under is preserved.Verified with
just pipeline-pack-validateagainst 0.5.3: 2/2 packages valid, pipeline exits 0.The same bump has been applied to the other ten repositories under
purview-dev, each verified the same way.