Add testing infrastructure for slang#272
Open
fischeti wants to merge 41 commits intofischeti/slang-picklerfrom
Open
Add testing infrastructure for slang#272fischeti wants to merge 41 commits intofischeti/slang-picklerfrom
fischeti wants to merge 41 commits intofischeti/slang-picklerfrom
Conversation
This was referenced Feb 17, 2026
fischeti
force-pushed
the
fischeti/slang-test
branch
from
c6356eb to
5a1fd38
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
from
038b5fa to
3795c0a
Compare
fischeti
force-pushed
the
fischeti/slang-test
branch
from
5a1fd38 to
1d36e68
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
from
3795c0a to
f295d10
Compare
fischeti
force-pushed
the
fischeti/slang-test
branch
6 times, most recently
from
13ff13e to
dc432c0
Compare
fischeti
force-pushed
the
fischeti/slang-pickler
branch
from
07a9b8f to
2644c35
Compare
fischeti
force-pushed
the
fischeti/slang-test
branch
from
dc432c0 to
9a4317a
Compare
Will result in ABI mismatches i.e. segfaults otherwise
Prevent multiple inclusion of the header by adding a traditional #ifndef/define/endif include guard (BENDER_SLANG_BRIDGE_H). This replaces the lone #pragma once for better portability and ensures the header can be safely included multiple times across translation units.
Introduce safe wrapper types for the opaque FFI objects and move the
extension methods into proper Rust structs to provide a clearer,
idiomatic API and safer ownership semantics.
- Add SyntaxTree wrapper around SharedPtr<ffi::SyntaxTree> with Clone,
display, as_debug, rename, and fmt impls (Display/Debug).
- Add SlangContext wrapper around UniquePtr<ffi::SlangContext> with new,
set_includes, set_defines, and parse returning a SyntaxTree.
- Replace new_session() to return SlangContext instead of raw pointer.
- Update callers: remove use of extension traits and change formatting
at pickling to use Debug/Display impls (write!("{:?}", renamed_tree)).
bender-slang: Fix windows build 2
fischeti
force-pushed
the
fischeti/slang-pickler
branch
from
2644c35 to
0ca1013
Compare
fischeti
force-pushed
the
fischeti/slang-test
branch
from
9a4317a to
4aa7806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added another testing repository in
tests/pickleto test out multiple SystemVerilog options. The testing is done on multiple levels:Unit tests
basic.rsJust checks that parsing is sucessful or proper error is returned when broken SV code is provided.
Refactoring tests
pickle.rsTests renaming feature of
--prefix/--suffixas well as file filtering with--topCLI regression
cli_regression.rsExisting test framework to check the emitted output against regression (to be enabled)
This is part 2 of 3 in a stack made with GitButler:
picklecommand #264