Persist window state across application sessions#19
Merged
Conversation
Closes #18. Window bounds and maximized state are now saved to preferences on resize/move/maximize/close and restored when a new window is opened. An off-screen saved position (e.g. a disconnected display) is discarded while keeping the saved size. https://claude.ai/code/session_014dsDoT4P7fxxWTuxNjAHmk
Fixes the CI typecheck failure: the new required windowState field was missing from the mock AppPreferences objects in ShellHandler and ThemeHandler tests. https://claude.ai/code/session_014dsDoT4P7fxxWTuxNjAHmk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add window state persistence to remember and restore window size, position, and maximized state across application sessions.
Key Changes
WindowManager enhancements:
PreferencesServicedependencyresize,move,maximize, andunmaximizeeventsWindow state validation:
isPositionOnScreen()to validate saved window positions against connected displaysType definitions:
WindowStateinterface to track width, height, x, y coordinates, and maximized stateAppPreferencesto includewindowStatefieldDEFAULT_WINDOW_STATEconstant for first-launch defaultsTest coverage:
Implementation Details
getNormalBounds()which reports un-maximized bounds, ensuring sensible dimensions are always saved even while maximizedhttps://claude.ai/code/session_014dsDoT4P7fxxWTuxNjAHmk