Conversation
This add/changes the bits needed for a Windows build, either by build tags (when Linux and Darwin) are in the same file, or using the correct file suffix (i.e. _windows.go for windows stuff). This is done exactly as done for the few Darwin stubs (also made Darwin uppercase 'D' everywhere). Thus this slightly re-arranges the code and adds a few stubs for Windows, without making any source code level changes. See psviderski#209 Note this *just* provides a Window and does not implement a socks proxy for Windows (if that is even necessary). ~~~ % GOOS=windows go build && ls uc.exe uc.exe % file uc.exe uc.exe: PE32+ executable for MS Windows 6.01 (console), ARM64, 14 sections % GOOS=windows GOARCH=amd64 go build && ls uc.exe % file uc.exe uc.exe: PE32+ executable for MS Windows 6.01 (console), x86-64, 16 sections ~~~ Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add/changes the bits needed for a Windows build, either by build tags (when Linux and Darwin) are in the same file, or using the correct file suffix (i.e. _windows.go for windows stuff). This is done exactly as done for the few Darwin stubs (also made Darwin uppercase 'D' everywhere).
Thus this slightly re-arranges the code and adds a few stubs for Windows, without making any source code level changes.
See #209
Note this just provides a Window and does not implement a socks proxy for Windows (if that is even necessary).