fix(torghut): keep completed activity source current during overlap scan#12877
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 848eb0c5e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address all unresolved current-head review feedback end to end. During an active overlap scan, report current only when the last completed watermark itself is within the configured freshness bound; do not let the scan's refreshed |
|
Codex couldn't complete this request. Try again later. |
89b2fb0 to
1ae2619
Compare
1ae2619 to
e809306
Compare
Summary
last_completed_atduring overlap scans instead of the scan-startupdated_atmainRelated Issues
Remediates the unresolved Codex finding on #12764 and the actionable findings introduced on this remediation PR.
Testing
env LD_LIBRARY_PATH=/workspace/runtime-libs .venv/bin/pytest tests/test_broker_account_activities.py tests/test_broker_account_activity_overlap_status.py -q(18 passed)Rollout
This changes the Torghut runtime image and readiness/status semantics. After merge, the image build, immutable digest promotion, Argo sync, migration/smoke hooks, workload readiness, restarts, logs, status endpoints, and post-deploy verification must be checked before original review threads are resolved.
Breaking Changes
None. Stale completed activity watermarks remain fail-closed.
Checklist