Skip to content

fix(torghut): keep completed activity source current during overlap scan#12877

Merged
gregkonush merged 1 commit into
mainfrom
codex/review-remediation-activity-scan-freshness
Jul 21, 2026
Merged

fix(torghut): keep completed activity source current during overlap scan#12877
gregkonush merged 1 commit into
mainfrom
codex/review-remediation-activity-scan-freshness

Conversation

@gregkonush

@gregkonush gregkonush commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

  • preserve a recently completed broker-account-activity watermark while a bounded overlap scan is running
  • calculate freshness from last_completed_at during overlap scans instead of the scan-start updated_at
  • keep stale historical watermarks fail-closed even when a new scan refreshes the cursor row
  • add focused fresh and stale overlap-scan regressions
  • replace the prior patch-runner head with a direct source commit rebased onto current main

Related Issues

Remediates the unresolved Codex finding on #12764 and the actionable findings introduced on this remediation PR.

Testing

  • env LD_LIBRARY_PATH=/workspace/runtime-libs .venv/bin/pytest tests/test_broker_account_activities.py tests/test_broker_account_activity_overlap_status.py -q (18 passed)
  • Ruff format and lint passed on all three changed Python files
  • complete required GitHub CI remains blocking before merge

Rollout

This changes the Torghut runtime image and readiness/status semantics. After merge, the image build, immutable digest promotion, Argo sync, migration/smoke hooks, workload readiness, restarts, logs, status endpoints, and post-deploy verification must be checked before original review threads are resolved.

Breaking Changes

None. Stale completed activity watermarks remain fail-closed.

Checklist

  • Testing section documents exact commands and results.
  • Screenshots are not applicable; Breaking Changes is filled in.
  • Rollout requirements are documented.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 848eb0c5e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/review-remediation.patch Outdated
Comment thread .github/review-remediation.patch Outdated

Copy link
Copy Markdown
Member Author

@codex address all unresolved current-head review feedback end to end. During an active overlap scan, report current only when the last completed watermark itself is within the configured freshness bound; do not let the scan's refreshed updated_at hide an old completion. Keep initial scans and stale completions fail-closed. Add focused regressions for both a fresh completed watermark during scanning and an hours-old completed watermark during scanning, run the relevant Torghut gates, and push the fix to this PR branch.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex couldn't complete this request. Try again later.

@gregkonush
gregkonush force-pushed the codex/review-remediation-activity-scan-freshness branch from 89b2fb0 to 1ae2619 Compare July 21, 2026 05:55
@gregkonush
gregkonush force-pushed the codex/review-remediation-activity-scan-freshness branch from 1ae2619 to e809306 Compare July 21, 2026 06:02
@gregkonush
gregkonush merged commit b9918c7 into main Jul 21, 2026
19 checks passed
@gregkonush
gregkonush deleted the codex/review-remediation-activity-scan-freshness branch July 21, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant