Skip to content

fix(torghut): reuse captured quote containers#12875

Merged
gregkonush merged 1 commit into
mainfrom
codex/review-remediation-rejected-quote-containers
Jul 21, 2026
Merged

fix(torghut): reuse captured quote containers#12875
gregkonush merged 1 commit into
mainfrom
codex/review-remediation-rejected-quote-containers

Conversation

@gregkonush

@gregkonush gregkonush commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

  • reuse assess_signal_quote_quality() when reconstructing rejected-signal entry snapshots
  • preserve the same quote aliases and nested executable_quote container semantics used by the accepted-signal path
  • add regression coverage using a captured nested NBBO quote rather than legacy top-level fields
  • replace the prior patch-runner head with a direct source commit rebased onto current main

Related Issues

Remediates the unresolved Codex finding on #12772.

Testing

  • env LD_LIBRARY_PATH=/workspace/runtime-libs .venv/bin/pytest tests/pipeline/test_trading_pipeline_quote_outcome.py -q (17 passed)
  • Ruff format and lint passed on both changed files
  • complete required GitHub CI remains blocking before merge

Rollout

This changes the Torghut runtime image. After merge, the image build, immutable digest promotion, Argo sync, migration/smoke hooks, current workloads, readiness, restarts, logs, and health endpoints must be verified before review threads are resolved.

Breaking Changes

None.

Checklist

  • Testing section documents exact commands and results.
  • Screenshots are not applicable; Breaking Changes is filled in.
  • Rollout requirements are documented.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18425c39fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/review-remediation.patch Outdated
@gregkonush
gregkonush force-pushed the codex/review-remediation-rejected-quote-containers branch from c90c0d8 to a9299d5 Compare July 21, 2026 05:15
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gregkonush
gregkonush marked this pull request as draft July 21, 2026 05:15
@gregkonush
gregkonush marked this pull request as ready for review July 21, 2026 05:15
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gregkonush
gregkonush force-pushed the codex/review-remediation-rejected-quote-containers branch from a9299d5 to 95fd03a Compare July 21, 2026 05:22
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gregkonush

Copy link
Copy Markdown
Member Author

@codex review

@gregkonush
gregkonush merged commit a2b232b into main Jul 21, 2026
19 checks passed
@gregkonush
gregkonush deleted the codex/review-remediation-rejected-quote-containers branch July 21, 2026 05:33
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 95fd03a419

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant