Skip to content

fix(torghut): bound sequential migration index builds#12873

Merged
gregkonush merged 3 commits into
mainfrom
codex/review-remediation-migration-deadline
Jul 21, 2026
Merged

fix(torghut): bound sequential migration index builds#12873
gregkonush merged 3 commits into
mainfrom
codex/review-remediation-migration-deadline

Conversation

@gregkonush

@gregkonush gregkonush commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

  • raise the Torghut migration hook deadline from 3,600 to 5,400 seconds so two sequential 30-minute concurrent index builds, two 300-second database waits, and remaining Alembic work fit inside the Kubernetes deadline
  • raise the post-deploy Argo convergence timeout to 5,700 seconds so verification cannot time out before the migration hook plus reconciliation headroom
  • add a Python manifest contract derived from migration 0083 and update the existing TypeScript manifest/workflow contracts
  • replace the prior patch-runner head with direct source commits rebased onto current main

Related Issues

Remediates the unresolved Codex finding on #12808 and the actionable review finding introduced on this remediation PR.

Testing

  • uv run --frozen --extra dev pytest tests/live_config_manifest_contract/test_db_migrations_deadline.py -q (1 passed before the final CI head)
  • bun test ./packages/scripts/src/torghut/__tests__/update-manifests.test.ts (5 passed)
  • bun test ./packages/scripts/src/torghut/__tests__/post-deploy-workflow.test.ts (24 passed)
  • complete Torghut CI run 29802249755 passed: bytecode/Ruff/migration guard, Pyright, PostgreSQL CAS, quality gates, both autoresearch runners, all four pytest shards, and aggregate coverage
  • scripts run 29802249805 passed; workflow/Argo/kubeconform validation run 29802249841 passed
  • final-head Codex review remains the only pre-merge gate

Rollout

After merge, Argo CD must apply activeDeadlineSeconds: 5400, the live PreSync migration hook must complete successfully, and the live Job definition must expose the new deadline. The post-deploy verification workflow must execute successfully with ARGO_SYNC_TIMEOUT_SECONDS=5700. Review threads will only be resolved after that evidence is captured.

Breaking Changes

None.

Checklist

  • Testing section documents exact commands and results.
  • Screenshots are not applicable; Breaking Changes is filled in.
  • Rollout requirements are documented.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec63e25f60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/review-remediation.patch Outdated

Copy link
Copy Markdown
Member Author

@codex inspect the repeated torghut-ci Pytest shard 0 failure on this PR. The manifest is 5,400 seconds, migration 0083 contains exactly two CREATE INDEX CONCURRENTLY statements and a 30-minute statement timeout, and the focused contract appears consistent. Read the full failed job logs, identify the exact failing test, fix only a PR-caused defect (or document and retrigger an unrelated baseline failure), run the focused contract plus full Torghut CI, and push any required correction.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: b4b4013c22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@gregkonush
gregkonush force-pushed the codex/review-remediation-migration-deadline branch from b4b4013 to 631d8f3 Compare July 20, 2026 09:05
@gregkonush
gregkonush marked this pull request as draft July 20, 2026 09:05
@gregkonush
gregkonush marked this pull request as ready for review July 20, 2026 09:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 631d8f34cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread argocd/applications/torghut/db-migrations-job.yaml
@gregkonush
gregkonush force-pushed the codex/review-remediation-migration-deadline branch from 631d8f3 to 1b8a768 Compare July 21, 2026 04:46
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gregkonush
gregkonush marked this pull request as draft July 21, 2026 04:46
@gregkonush
gregkonush marked this pull request as ready for review July 21, 2026 04:46
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gregkonush
gregkonush marked this pull request as draft July 21, 2026 04:55
@gregkonush
gregkonush marked this pull request as ready for review July 21, 2026 04:55
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gregkonush

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gregkonush
gregkonush merged commit 04f7cce into main Jul 21, 2026
28 checks passed
@gregkonush
gregkonush deleted the codex/review-remediation-migration-deadline branch July 21, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant