fix(torghut): repair empty TigerBeetle stable refs#12871
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 591a6e353d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 417c085aa7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10dea8b932
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address all unresolved current-head review feedback end to end. The branch now uses typed JSONB equality instead of the nonexistent |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc170ff970
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c9aca4083
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8c9aca4 to
2dcd041
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
{}stable-reference payloads without unsupported PostgreSQL JSONB functionsmainRelated Issues
Remediates the unresolved Codex finding on #12818 and the actionable findings introduced on this remediation PR.
Testing
env LD_LIBRARY_PATH=/workspace/runtime-libs .venv/bin/pytest tests/test_backfill_tigerbeetle_stable_refs.py -q(14 passed).venv/bin/ruff format --check app/trading/tigerbeetle_journal/stable_ref_backfill.py tests/test_backfill_tigerbeetle_stable_refs.py.venv/bin/ruff check app/trading/tigerbeetle_journal/stable_ref_backfill.py tests/test_backfill_tigerbeetle_stable_refs.pyRollout
This changes the Torghut runtime image. After merge, the multi-architecture image build, digest promotion PRs, Argo sync, migration and TigerBeetle smoke hooks, workload readiness, restarts, logs, and health endpoints must be verified before review threads are resolved.
Breaking Changes
None. Existing non-empty stable references remain immutable.
Checklist