fix(talos): make flannel ownership singular#12753
Conversation
dcb550f to
b58eecd
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b58eecd514
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The custom CNI delegate does not change Flannel's backend MTU, and `/run/flannel/subnet.env` may still report | ||
| `FLANNEL_MTU=1450` on a normal 1500-byte underlay. Do not continue workload validation unless the ConfigMap value is |
There was a problem hiding this comment.
packages/scripts/src/docs/__tests__/flannel-mtu-runbook.test.ts:14 asserts the contiguous string may still report \FLANNEL_MTU=1450`, but this edit splits it across two source lines, so bun test packages/scripts/srcfails. This change triggers that suite through.github/workflows/scripts-ci.yml`; either preserve the phrase as one line or update the runbook test for the new wording.
Useful? React with 👍 / 👎.
9acccd8 to
f3394ee
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3394ee9fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: custom | ||
| urls: | ||
| - https://raw.githubusercontent.com/proompteng/lab/15f59fd037dd45ecd79cf69031215d1e79b6b479/devices/galactic/manifests/flannel-v0.28.5-mtu1400.yaml |
There was a problem hiding this comment.
The canonical new-control-plane procedure in devices/galactic/docs/add-control-plane-node.md:85-91 does not apply this patch, so a control plane added with that command retains Talos's default name: flannel configuration. That node can then reconcile Talos's generated Flannel resources over the cluster-wide ConfigMap/DaemonSet, reintroducing a competing owner and reverting the required 1400 CNI delegate MTU. Add this patch to the join workflow (or otherwise make it part of every control-plane machine configuration).
Useful? React with 👍 / 👎.
1 participant
Summary
15f59fd037dd45ecd79cf69031215d1e79b6b479flannel-cniapplication and its ConfigMap-only ownershipRelated Issues
None
Testing
talosctl gen config custom-cni-test https://127.0.0.1:6443 --config-patch @devices/galactic/manifests/custom-flannel-cni.patch.yaml --output-types controlplane ...talosctl validate --config <generated-controlplane.yaml> --mode metal --strictbun test packages/scripts/src/shared/__tests__/talos-flannel.test.ts packages/scripts/src/shared/__tests__/enabled-apps.test.tskubeconform -strict -summary devices/galactic/manifests/flannel-v0.28.5-mtu1400.yamle70285f0a94b1d8402963164b3065577f89fd1bd5d0ad611e933fcb96bdeda1abun run lint:argocdbunx oxfmt --check ...git diff --checkRollout and impact
Do not merge until all three control-plane nodes and etcd quorum are healthy. Apply the checked-in Talos patch to every node first, verify the custom manifest is applied and networking remains healthy, then merge so Argo relinquishes the preserved ConfigMap. Remove the stale Argo preservation annotation only after the Application is absent.
Breaking Changes
The
flannel-cniArgo Application is retired. Talos becomes the sole owner of the complete Flannel bundle; rollback after merge must restore the Argo guard before switching Talos back to generated Flannel.Checklist