test(inventory): make mixed-format fixture deterministic - #1835
test(inventory): make mixed-format fixture deterministic#1835mldangelo-oai wants to merge 1 commit into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
The latest Nightly CI run failed the Windows Python 3.11 asset-inventory test because random SafeTensors data selected pickle-overlap routing, while the test expected SafeTensors metadata.
Use fixed zero-filled tensors in the shared mixed-format fixture and keep the nested tensor file under
tmp_path. The existing assertions still check the nested format, tensor names, and pickle warning. Scanner behavior is unchanged.Validation:
pickle != safetensorsassertion by supplyingRandomState(230).randnas the fixture's random source; the same invocation passes after this change.