Merged
Conversation
This picks this sveltos-agent optmization: Both sveltos-agent and the agents running in the control cluster (classifier, event-manager and healthcheck-manager) update status for ClassifierReport, EventReport and HealthCheckReport. Sveltos-agent updates it to indicate there is a new report to be processed. The agents in the control cluster to indicate the latest report has been processed. This PR optimizes the status update logic for the EventReport, HealthCheckReport, and ClassifierReport controllers. Previously, concurrent updates by multiple managers or controllers some time resulted in 409 Conflict errors. This forced the classifier/eventSource/healthCheck to be re-evaluated again. The code now attempts an immediate status update with the existing resourceVersion. It only performs a Get() request if a conflict is actually detected, saving one API call in ~90% of cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks this sveltos-agent optmization:
Both sveltos-agent and the agents running in the control cluster (classifier, event-manager and healthcheck-manager) update status for ClassifierReport, EventReport and HealthCheckReport.
Sveltos-agent updates it to indicate there is a new report to be processed. The agents in the control cluster to indicate the latest report has been processed.
This PR optimizes the status update logic for the EventReport, HealthCheckReport, and ClassifierReport controllers.
Previously, concurrent updates by multiple managers or controllers some time resulted in 409 Conflict errors. This forced the classifier/eventSource/healthCheck to be re-evaluated again.
The code now attempts an immediate status update with the existing resourceVersion. It only performs a Get() request if a conflict is actually detected, saving one API call in ~90% of cases.