Skip to content

fix: vertically center dropdown label (ported to main) #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lirenjie95 wants to merge 3 commits into from
Closed

fix: vertically center dropdown label (ported to main) #1501

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c071269
fix: vertically center dropdown label
lirenjie95 Jul 1, 2026
0d94f17
refactor: use flex layout for collapsed dropdown, drop absolute icon …
lirenjie95 Jul 2, 2026
b4092b3
refactor: apply flex layout to dropdown options and use spacing varia…
lirenjie95 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 32 additions & 9 deletions src/components/Dropdown/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,26 @@
width: 100%;
height: 100%;
cursor: pointer;
display: flex;
align-items: center;
gap: var(--spacing-xs);
padding: 0 var(--spacing-xs);
@media (hover: hover) and (pointer: fine) {
&:hover {
border: 1px solid var(--accent-color);
background-color: var(--accent-type-color);
color: var(--accent-color);
}
}

.iconTop,
.chevron {
position: static;
}

.chevron {
margin-left: auto;
}
}

.options {
Expand All @@ -37,17 +50,23 @@
}

.option {
padding-left: 0;
padding: 7px 0;
cursor: pointer;
position: relative;
display: flex;
align-items: center;
gap: var(--spacing-xs);
padding: var(--spacing-xs);

.icon {
position: static;
}

button {
width: 100%;
height: 100%;
flex: 1;
text-align: left;
background: none;
border: none;
cursor: pointer;
padding: 0;
}
}

Expand Down Expand Up @@ -117,16 +136,20 @@ button.chevron {
.selected > span,
.option > button > span {
text-align: left;
padding-left: 44px;
// 38px padding-right holds the chevron icon on mobile for better touch targets
padding-right: 38px;
display: inline-block;
width: 100%;
// 0.75rem font-size for mobile to fit content in smaller screens
font-size: 0.75rem;

@media (min-width: variables.$breakpoint-tablet) {
font-size: 1rem;
padding-right: 10px;
}
}

.selected > span {
flex: 1;
}

.option > button > span {
padding-right: var(--spacing-sm);
}