apply: Log every migration that is applied - #48
Merged
Conversation
Only the reset/fresh-database path logged per-migration; the incremental path calls m.Up() once, so a container running 'trek apply' against an existing database only printed 'Successfully migrated database'. Attaching a logger to go-migrate makes it report every applied migration on both paths, which also replaces the reset path's own log line.
There was a problem hiding this comment.
Pull request overview
This PR updates the trek apply command to consistently log each migration that gets applied, including when running incrementally against an existing database (where m.Up() previously only emitted a final success message).
Changes:
- Adds a small
migrateLoggeradapter to attach a logger to go-migrate. - Sets
m.Logso go-migrate reports each applied migration. - Removes the reset-path’s manual per-migration log line (now redundant).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the reset/fresh-database path logged per-migration; the incremental path calls m.Up() once, so a container running 'trek apply' against an existing database only printed 'Successfully migrated database'.
Attaching a logger to go-migrate makes it report every applied migration on both paths, which also replaces the reset path's own log line.