Repository navigation
Conversation
Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #996.
@xml-tools/parserhas no grammar rule for the internal subset of a DOCTYPE (<!DOCTYPE x [ <!ENTITY ...> ]>), so the lexer throws on the[.parser.jsnow finds the[ ... ]range before parsing (skipping quoted strings and comments, so a]inside an entity value or comment doesn't end it early). It blanks that range with spaces, which keeps every offset and line number the same, and parses the rest as before. The raw text goes on thedocTypeDeclnode asinternalSubset, and the printer writes it back unchanged between[and]. The DTD content is not reformatted.Added a parser test, a format test (including
]inside a quoted value and a comment, and a second pass to check the output is stable), and a CHANGELOG line.Ran live:
printf '<!DOCTYPE x [<!ENTITY nbsp " ">]>\n<a>hi</a>\n' > t.xml && npx prettier --plugin ./src/plugin.js --parser xml t.xml-> prints the file back unchanged (wasSyntaxError: unexpected character: ->[<-).