Skip to content

Ninja fix broken build dependencies#2689

Merged
samsinsane merged 1 commit into
premake:masterfrom
nickclark2016:fix-broken-dependencies-ninja
May 23, 2026
Merged

Ninja fix broken build dependencies#2689
samsinsane merged 1 commit into
premake:masterfrom
nickclark2016:fix-broken-dependencies-ninja

Conversation

@nickclark2016
Copy link
Copy Markdown
Member

What does this PR do?

Fixes dependson only actions that affect subsequent builds via prebuild/postbuild/prelink events.

How does this PR change Premake's behavior?

Fixes project phonies on postbuilds, adds dependencies for build events that rely on prebuild/postbuild/prelink events of depended upon projects.

Anything else we should know?

No

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 requested a review from a team May 22, 2026 17:43
@nickclark2016 nickclark2016 changed the title Fix broken build dependencies Ninja fix broken build dependencies May 22, 2026
@nickclark2016 nickclark2016 force-pushed the fix-broken-dependencies-ninja branch from fa3261a to 4ee914a Compare May 22, 2026 17:55
@samsinsane samsinsane merged commit 188ae1b into premake:master May 23, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants