Repository navigation
chore: bump typescript to v7 and migrate to oxlint and oxfmt - #289
Merged
Merged
Conversation
- replace eslint + typescript-eslint with oxlint (type-aware via oxlint-tsgolint, with type checking) - replace prettier with oxfmt - port the strictTypeChecked + stylisticTypeChecked + eslint recommended rule set - fix sha256 parameter type flagged by TS 7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps TypeScript to v7 and replaces ESLint/typescript-eslint and Prettier with oxlint and oxfmt.
typescript-eslint doesn't support TS 7 yet (it needs the TS 7.1 JS API, see typescript-eslint/typescript-eslint#10940), which is why #288 stayed on TS 6. oxlint's type-aware linting runs on tsgolint (typescript-go) and actually requires TS 7.
.oxlintrc.json): oxlint'scorrectnesscategory plus a few rules we relied on before (no-unsafe-*,no-explicit-any,prefer-nullish-coalescing,no-unused-varswith^_args). Type-aware linting and type checking (typeCheck) are enabled, so lint also runs a full TS 7 typecheck. This is intentionally lighter than the oldstrictTypeChecked+stylisticTypeCheckedpresets..oxfmtrc.json): migrated from the Prettier config viaoxfmt --migrate=prettier; TOML files are ignored to keep the same scope Prettier had.lint/fmtapply fixes,lint:check/fmt:checkonly check; CI runs the:checkvariants as separate steps.eslint-disablecomments renamed tooxlint-disable(two that became unused were removed).sha256(BinaryLikeincludesArrayBuffer, whichhash.updatedoesn't accept)..vscode/settings.jsonnow uses the oxc extension as formatter.dist/is unchanged (tsup builds with esbuild).