Repository navigation
fix(lock): key pypi wheel tags check on rich platform name - #7299
Open
Tyagiquamar wants to merge 4 commits into
Open
Tyagiquamar wants to merge 4 commits into
Tyagiquamar wants to merge 4 commits into
Conversation
…v#7040) Signed-off-by: Mohd Quamar Tyagi <104281681+Tyagiquamar@users.noreply.github.com>
Reintroduce workspace platform resolution when building the per-lock-platform PyPI wheel tag cache so pixi_core compiles and rich platform names stay keyed correctly.
Store lock platform names as String in the PyPI wheel tag map so the struct matches the rich-platform lookup path.
Signed-off-by: Tyagiquamar <Tyagiquamar@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7040
Previously in
crates/pixi_core/src/lock_file/satisfiability/environment.rs,PypiWheelTagsCheckstored wheel tags keyed bylock_platform.subdir()(Subdir/ conda platform).When multiple rich platforms share the same underlying conda subdir (such as
linux-64and a rich platformlinux-newspecifying a newerglibcor other virtual package requirements), both platforms collided on the sameSubdirkey inplatform_wheel_tags: HashMap<Subdir, Tags>. BecauseHashMapiteration is nondeterministic across processes, one platform overwrote the other, causingpixi lock --checkto nondeterministically pass or fail on identical lockfiles with:Changes
platform_wheel_tagsby the unique lock platform name (String), which uniquely distinguishes rich platforms sharing a common subdir.check(&self, platform: &str, ...)to look up tags by platform name.Checklist: