-
Notifications
You must be signed in to change notification settings - Fork 2
Support per dataset loads with debug #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rintcius
wants to merge
2
commits into
master
Choose a base branch
from
ENG-74-per-dataset-load-debug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -948,10 +948,20 @@ paths: | |
| responses: | ||
| '202': | ||
| description: Accepted - there are in-band datasets and a load has been scheduled to start | ||
| content: | ||
| application/json: | ||
| schema: | ||
| type: string | ||
| minLength: 1 | ||
| description: Pipeline load ID | ||
| '204': | ||
| description: No Content - there are no in-band datasets | ||
| '400': | ||
| description: Bad Request - there are no datasets in pipeline | ||
| description: Bad Request - the body is invalid or there are no datasets in the pipeline | ||
| content: | ||
| text/plain: | ||
| schema: | ||
| type: string | ||
| '401': | ||
| description: Unauthorized | ||
| '402': | ||
|
|
@@ -978,6 +988,16 @@ paths: | |
| - error | ||
| '404': | ||
| description: Pipeline not found. | ||
| content: | ||
| text/plain: | ||
| schema: | ||
| type: string | ||
| '500': | ||
| description: The load request failed, including when another load is already in progress. | ||
| content: | ||
| text/plain: | ||
| schema: | ||
| type: string | ||
| '502': | ||
| description: Problematic Request to External Server | ||
| content: | ||
|
|
@@ -986,14 +1006,15 @@ paths: | |
| $ref: '#/components/schemas/error-message' | ||
| description: Start a load for this pipeline. | ||
| requestBody: | ||
| required: false | ||
| content: | ||
| application/json: | ||
| schema: | ||
| type: object | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this isn't there anymore. Perhaps better to leave this endpoint unchanged and create a new one |
||
| properties: | ||
| returnUrl: | ||
| type: string | ||
| description: '' | ||
| $ref: '#/components/schemas/pipeline-load-request' | ||
| description: >- | ||
| Omit the body, omit `datasets`, or send an empty object to start a full load with | ||
| debug disabled. A non-empty `datasets` array starts a partial load. An empty array, | ||
| malformed entry, or repeated dataset ID is rejected with a 400 response. | ||
| '/pipelines/{pipeline-id}/rename': | ||
| parameters: | ||
| - schema: | ||
|
|
@@ -2704,6 +2725,10 @@ components: | |
| properties: | ||
| initialWrite: | ||
| type: boolean | ||
| debug: | ||
| type: boolean | ||
| default: false | ||
| description: Enable immediate reader logging for this dataset's initial load. | ||
| readRequired: | ||
| type: boolean | ||
| default: false | ||
|
|
@@ -2716,6 +2741,34 @@ components: | |
| $ref: '#/components/schemas/initial-load-params-message-limit' | ||
| required: | ||
| - initialWrite | ||
| pipeline-load-request: | ||
| title: pipeline-load-request | ||
| type: object | ||
| additionalProperties: false | ||
| properties: | ||
| datasets: | ||
| type: array | ||
| minItems: 1 | ||
| uniqueItems: true | ||
| description: >- | ||
| Datasets to include in a partial standard load. Dataset IDs must be unique. | ||
| Unknown IDs are ignored; if none belong to the pipeline, the request fails. | ||
| items: | ||
| $ref: '#/components/schemas/pipeline-load-dataset-options' | ||
| pipeline-load-dataset-options: | ||
| title: pipeline-load-dataset-options | ||
| type: object | ||
| additionalProperties: false | ||
| properties: | ||
| id: | ||
| type: string | ||
| minLength: 1 | ||
| debug: | ||
| type: boolean | ||
| default: false | ||
| description: Enable immediate reader logging for this dataset's load. | ||
| required: | ||
| - id | ||
| initial-load-params-message-limit: | ||
| title: initial-load-params-message-limit | ||
| type: object | ||
|
|
@@ -2906,6 +2959,27 @@ components: | |
| minLength: 1 | ||
| loadParameters: | ||
| $ref: '#/components/schemas/initial-load-params' | ||
| datasetOverrides: | ||
| type: object | ||
| description: Initial-load parameter overrides keyed by dataset ID. | ||
| additionalProperties: | ||
| $ref: '#/components/schemas/optional-initial-load-params' | ||
| optional-initial-load-params: | ||
| title: optional-initial-load-params | ||
| type: object | ||
| properties: | ||
| initialWrite: | ||
| type: boolean | ||
| debug: | ||
| type: boolean | ||
| readRequired: | ||
| type: boolean | ||
| reusePreviousSchema: | ||
| type: boolean | ||
| reusePreviousPrimaryKey: | ||
| $ref: '#/components/schemas/reuse-previous-primary-key' | ||
| sampleParameters: | ||
| $ref: '#/components/schemas/initial-load-params-message-limit' | ||
| error-message: | ||
| title: error-message | ||
| type: object | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text/plain -> remove I'd say