Make clean.sh scripts executable from any directory#751
Open
k4rtikx wants to merge 1 commit intoprecice:developfrom
Open
Make clean.sh scripts executable from any directory#751k4rtikx wants to merge 1 commit intoprecice:developfrom
k4rtikx wants to merge 1 commit intoprecice:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix clean.sh scripts so they can be executed from any directory.
Many case-level clean.sh scripts source ../../tools/cleaning-tools.sh using
relative paths. When invoked from outside their directory (e.g.
./fluid-openfoam/clean.sh), the working directory differs and the relative
path breaks.
This PR ensures scripts always execute from their own directory by adding:
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
cd "$SCRIPT_DIR"
Changes:
(the only non-symlink clean-tutorial.sh)
set -e -utoflow-around-controlled-moving-cylinder/solid-python/clean.sh
Verification: