feat(systemtests): add per-test max_time override for precice-config closes#402#738
Open
PranjalManhgaye wants to merge 5 commits intoprecice:developfrom
Open
feat(systemtests): add per-test max_time override for precice-config closes#402#738PranjalManhgaye wants to merge 5 commits intoprecice:developfrom
PranjalManhgaye wants to merge 5 commits intoprecice:developfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
MakisH
added
GSoC
Collaborator
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-pranjal-manhgaye/2769/6 |
PranjalManhgaye
force-pushed
the
issue-402-max-time-override
branch
from
9da11ce to
fb5ba1c
Compare
…ix precice#402) - TestSuite parses max_time from tests.yaml - Systemtest applies override to <max-time> in precice-config.xml - Applies to both test runs and reference result generation - Validate positive max_time; handle multiple tags with warning - Use regex targeting <max-time> only
PranjalManhgaye
force-pushed
the
issue-402-max-time-override
branch
from
a9e37e0 to
7a35f7b
Compare
Contributor
Author
|
this version adds validation for max_time and a regex that only touches (not other attributes) , thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for an optional max_time field per tutorial entry in tools/tests/tests.yaml.
TestSuite parses max_time and passes it to each Systemtest instance as max_time.
Before running a test, Systemtest now optionally overrides in the copied precice-config.xml, if max_time is set and exists.
No existing tutorials or reference results are modified; the PR only adds the override mechanism, so behavior is unchanged unless a max_time entry is added in tests.yaml.
This is complementary to PR #734, which adds a wall‑clock --timeout for the systemtest subprocess; this PR implements the config‑level restriction requested in #402.
Checklist:
changelog-entries/<PRnumber>.md.