Merged
Conversation
MakisH
reviewed
Aug 11, 2025
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Thank you for the clean PR! See some first comments on the structure.
I have not yet looked into the codes or the parameters, I would do that once the locations of the files have converged, to not lose track of the suggestions and changes.
The 3D and 3D-3D cases run, anything with the 1D code does not at the moment, but this is probably related to my system (see also #648 (comment)).
Please add some content to the PR description as well.
water-hammer/case-1d-3d/fluid3d-openfoam/constant/thermodynamicProperties
Outdated
Show resolved
Hide resolved
MakisH
reviewed
Sep 16, 2025
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
REmove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
…nto WaterHammerTutorial
MakisH
reviewed
Mar 9, 2026
MakisH
reviewed
Mar 9, 2026
MakisH
added a commit
to precice/precice.github.io
that referenced
this pull request
Mar 9, 2026
I sometimes face this issue on my system, and it might be useful for others as well. Transferring documentation from precice/tutorials#660 (comment).
MakisH
reviewed
Mar 9, 2026
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
I tried all combinations, they all start and the plotting script works for all.
Some small changes in the plotting script would make this easier to use.
1 task
MakisH
reviewed
Mar 9, 2026
Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>
Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>
MakisH
reviewed
Mar 10, 2026
MakisH
approved these changes
Mar 10, 2026
github-project-automation
bot
moved this from In Progress
to Done
in Geometric multiscale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new Partitioned Water Hammer tutorial demonstrating transient 1D–3D coupling with preCICE for compressible pipe flow.
The tutorial is particularly relevant as it provides a transient benchmark for testing the axial geometric multiscale mapping under wave-propagation conditions. Unlike steady pipe examples, this case introduces pressure waves traveling across the coupling interface, making it a meaningful validation scenario for mixed-dimensional coupling.
It includes 1D–3D and 3D-1D, as well as 1D–1D and 3D–3D configurations for comparison and validation.
Checklist:
changelog-entries/<PRnumber>.md.