Fix banner load callbacks firing before creative attachment#948
Open
mdanylov-sigma wants to merge 1 commit into
Open
Fix banner load callbacks firing before creative attachment#948mdanylov-sigma wants to merge 1 commit into
mdanylov-sigma wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1220
Summary
Fixed the banner/custom renderer load callback ordering on both iOS and Android so the load callback is not fired before the creative view is attached.
Android
Updated
PrebidDisplayView.javasoadLoadedmarks the load notification as pending instead of notifying immediately.When
viewReadyForImmediateDisplayis called, the creative is attached first, then pendingonAdLoadedis fired, followed byonAdDisplayed.Added regression coverage in
PrebidDisplayViewTest.javato verify that:onAdLoadedis not fired before the creative is readyonAdLoadedfiresonAdLoadedstill fires beforeonAdDisplayed