Synapse HX Bid Adapter : initial release#15331
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8a3686751
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| netRevenue: true, | ||
| ttl: 30 | ||
| }, | ||
| translator: toOrtb26 |
There was a problem hiding this comment.
When consent modules are enabled in real auctions, Prebid normalizes GDPR/USP consent into ORTB 2.5-style paths such as regs.ext.gdpr, regs.ext.us_privacy, and user.ext.consent, but ortbConverter does not consume a translator option, so this line is a no-op. As a result, the Synapse ORTB 2.6 endpoint will not receive the regs.gdpr, regs.us_privacy, or user.consent fields that the adapter tests expect unless toOrtb26(data) is applied explicitly after converter.toORTB(...) or inside the request customizer.
Useful? React with 👍 / 👎.
| method: METHOD, | ||
| url: makeUrl(bidRequests), | ||
| options: { | ||
| contentType: 'application/json', |
There was a problem hiding this comment.
For browser auctions this is a cross-origin POST with credentials, and Content-Type: application/json is not CORS-safelisted, so each bid request can incur an OPTIONS preflight and can fail entirely if the exchange does not answer preflight before the auction timeout. Prebid's bidderFactory already stringifies object payloads for POSTs, so using text/plain avoids the extra round trip unless this endpoint explicitly requires preflighted JSON.
Useful? React with 👍 / 👎.
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| method: METHOD, | ||
| url: makeUrl(bidRequests), | ||
| options: { | ||
| contentType: 'application/json', |
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
Barecheck - Code coverage reportTotal: 96.57%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
2 participants
Type of change
Description of change
New bidder adapter for Synapse HX
Maintainer: prebid@compas-inc.com
Other information
Docs PR - prebid/prebid.github.io#6657