fix: use Docusaurus Link component for pathname:// booklet links - #10
Open
nerdalert wants to merge 1 commit into
Open
fix: use Docusaurus Link component for pathname:// booklet links#10nerdalert wants to merge 1 commit into
nerdalert wants to merge 1 commit into
Conversation
Plain <a> tags don't understand the pathname:/// protocol — switch to Docusaurus's <Link> which resolves it correctly. Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the homepage visual-guide card links so Docusaurus resolves the
pathname:///static-file URLs correctly.The guide cards in
src/pages/index.tsxwere using plain<a>tags, which renderedpathname:///...directly into the DOM. Browsers treatpathname:as an unknown protocol, so the booklet links did not navigate correctly. Docusaurus’s<Link>component understands this escape hatch and renders the expected static-file paths.Also fixes an unrelated broken docs anchor by pointing the payload-processing reference at the dedicated architecture page.
Changes
<Link>component on the homepage<a>tags with<Link>pathname:///hrefs unchanged[payload-processing]reference fromsystem-design#payload-processingtoarchitecture/payload-processingTest plan
npx docusaurus buildsucceeds/praxis-core-booklet.html,/praxis-ai-booklet.html, and/praxis-grid-booklet.htmlpayload-processinganchor warning