poc integration#37
Open
jpoikela wants to merge 3 commits into
Open
Conversation
Author
|
hmmm. I'll have to remove the formatting differences, and leave only the code changes |
Owner
|
Yes, please! It's too confusing the way it is now.
Paulo
…On Mon, Aug 6, 2018 at 11:14 AM Jani Poikela ***@***.***> wrote:
hmmm. I'll have to remove the formatting differences, and leave only the
code changes
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AArloJ7vjxpgZIgro1BbUVvEKZgEfxhbks5uOE9TgaJpZM4Vwd28>
.
|
jpoikela
force-pushed
the
lha_integration
branch
from
f0f7ad3 to
4c0da20
Compare
Author
|
I updated the LHA decoder and now also ROM loading works for example with ROM |
Author
|
I would call it a breakthrough :) |
jpoikela
commented
Aug 13, 2018
| return null; | ||
| }; | ||
|
|
||
| this.getLHAFilesSorted = function (lha) { |
Author
There was a problem hiding this comment.
could use getZIPFilesSorted() instead
jpoikela
commented
Aug 13, 2018
| return diskDrive.loadAsDiskFromFiles(port, name, self.createTreeFromZip(zip), altPower, asExpansion); // throws | ||
| } | ||
|
|
||
| function tryLoadLhaAsDisk(name, lha, port, altPower, asExpansion) { // throws |
Author
There was a problem hiding this comment.
could use tryLoadZipAsDisk() instead
Author
|
FileLoader.loadFromContentAsSlot still needs LHA handling |
Owner
|
Hey Jani! Log time! Anything I can use? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.