Dont crash on unsendable errors - #454
Merged
Merged
Conversation
simolus3
marked this pull request as ready for review
August 3, 2026 10:26
simolus3
force-pushed
the
dont-crash-on-unsendable-errors
branch
from
August 5, 2026 09:14
121035e to
76e99e8
Compare
Chriztiaan
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a backend connector throwing an exception that can't be sent across isolates causes the sync isolate to become stuck.
This can happen for errors that include an asynchronous primitive like
Completer, which is the case for some errors thrown by the populardiopackage for http requests. Sending these across ports throws, soPortCompleter.completeErrorwould fail without ever sending the error to the sync isolate. That then causes the sync isolate to wait for a response indefinitely, blocking evendisconnect()requests.To fix this, we send a serialized
toString()representation if the original error is unsendable. We also use capabilities (a special object that comes back unchanged when sent across isolates) and a weak map to recover the underlying error on the main isolate after it shows up as anuploadError/downloadError.