[MSSQL] Ensure consistent ordering of CDC operations - #742
Open
Rentacookie wants to merge 8 commits into
Open
Conversation
- Ensure correct ordering of CDC results - Handle deferred updates - Correctly count processed transactions in each polling cycle - Improved logging - Added tests
🦋 Changeset detectedLatest commit: d34145f The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Cleaned up cdc operation grouping function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue that was discovered where deferred updates could result in missing row updates.
Deferred updates are recorded in the CDC tables as a paired
DELETEandINSERToperation, with the 2 operations having the same sequence number in the same transaction. This caused problems with the ordering of operations in the same transaction and theINSERTcould be processed before theDELETEcausing the replicated row to disappear.Changes
operationas a tie breaker when ordering CDC results within a transaction.Testing
Added new CDCPoller.test.ts unit tests which helped diagnose the main issue and confirms the fixes.
AI Disclosure
Used Clause Opus 5 to replicate the issue with tests and implement then implement the fix. Also reviewed and verified changeds with GPT 5.6.