Skip to content

fix(cfs): exclude non-physical relations #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kmortyk wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(cfs): exclude non-physical relations #236

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c5686e
fix(cfs): exclude non-physical relations
Aug 28, 2026
62dbf99
fix(cfs): add materialized
Aug 28, 2026
e2741e5
fix(cfs): remove 'pg_default' and 'pg_global'
Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions mamonsu/plugins/pgsql/cfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,18 @@ class Cfs(Plugin):
}

query_cfs_compressed_ratio = """
WITH cfs_data AS MATERIALIZED (
SELECT
n.nspname || '.' || c.relname AS table_name,
cfs_compression_ratio(c.oid::regclass) AS ratio,
(pg_catalog.pg_total_relation_size(c.oid::regclass) - pg_catalog.pg_indexes_size(c.oid::regclass)) AS compressed_size
FROM
pg_catalog.pg_class AS c
LEFT JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
WHERE c.reltablespace IN (SELECT oid FROM pg_catalog.pg_tablespace WHERE spcoptions::text ~ 'compression')
AND c.relkind IN ('r','v','m','S','f','p','')
AND cfs_compression_ratio(c.oid::regclass) <> 'NaN'
WHERE c.reltablespace IN (
SELECT oid FROM pg_catalog.pg_tablespace
WHERE spcoptions::text ~ 'compression' AND spcname NOT IN ('pg_default', 'pg_global')
) AND c.relkind IN ('r','m','S') -- only relkinds with physical storage

UNION ALL

Expand All @@ -34,9 +36,12 @@ class Cfs(Plugin):
FROM
pg_catalog.pg_class AS c
LEFT JOIN pg_catalog.pg_namespace n ON n.oid = c.relnamespace
WHERE c.reltablespace IN (SELECT oid FROM pg_catalog.pg_tablespace WHERE spcoptions::text ~ 'compression')
AND c.relkind = 'i'
AND cfs_compression_ratio(c.oid::regclass) <> 'NaN';
WHERE c.reltablespace IN (
SELECT oid FROM pg_catalog.pg_tablespace
WHERE spcoptions::text ~ 'compression' AND spcname NOT IN ('pg_default', 'pg_global')
) AND c.relkind = 'i'
-- subquery + outer NaN filter prevent planner from calling cfs_compression_ratio() before reltablespace/relkind filters
) SELECT table_name, ratio, compressed_size FROM cfs_data WHERE ratio <> 'NaN';
"""

query_cfs_activity = """
Expand Down