Conversation
aleks-f
approved these changes
Sep 26, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Flat import of platform/XSD from macchina.io (state of 2026-09-21); the Applied Informatics changes since the common base follow as separate commits. Not imported: samples-internal, CodeGen/data and the Validator vcpkg manifests. Co-Authored-By: Aleksandar Fabijanic <aleks-f@users.noreply.github.com> Co-Authored-By: Matej Kenda <matejken@gmail.com> Co-Authored-By: Lara Dzivdzanovic <dzivdzanoviclara@gmail.com>
…BSL-1.0 SPDX line #5450
…orted the parse #5450 Expat calls the end-element and end-namespace handlers of an empty element after XML_StopParser(); the XSD Parser content handler popped an empty stack on the forwarded event.
… builds, CI and documentation #5450 Also GCC symbol visibility, compiler warnings, per-context libxml2 error handling, testsuite conventions and the Validator in the CodeQL build.
…d XSDGen default values #5450
… concise comments #5450 Also the CodeQL notes (shadowed variables, empty if, commented-out code) and a shared parser test helper.
…ons, parser crashes, XSDGen code injection #5450 The Validator parses the schema text without entity substitution; the Parser rejects locations on other network hosts and XML Schema elements in WSDL extension content, and handles XSD elements in xs:documentation; XSDGen rejects Remoting attribute values that end the comment line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5450.
XSD moves from macchina.io into POCO:
XSD/Types(schema object model),XSD/Parser(XML Schema andWSDL parser),
XSD/CodeGen(XSDGen, used by the RemotingNG SOAP samples) andXSD/Validator(validation on libxml2). Flat import plus the two later Applied Informatics commits with their
authorship; all files are BSL-1.0.
ENABLE_XSD_VALIDATORoff by default and off withoutlibxml2, as SSH. CodeQL also analyses the Validator.
text is parsed without entity substitution and may not declare external DTDs or entities; schemas are trusted.
xs:documentationand WSDLextension content no longer crash it (found by fuzzing).
//@comment line are rejected.noexceptspecifiers #5152 attributes; unusable public API removed.fix(XML):ParserEngineforwarded Expat events after an aborted parse.The CodeQL XXE alerts on
SAXParserare false positives (external entities are off by default), dismissed as #752/#754/#755.Tests: macOS and Linux, CMake and make, C++17, ASan/UBSan/TSan, fuzzing, clang-tidy/cppcheck, each commit
on its own; XSDGen output identical on the SOAP samples.