feat(pad-config): keep stepping thresholds while Up/Down is held - #689
Draft
ddrcoder wants to merge 2 commits into
Draft
feat(pad-config): keep stepping thresholds while Up/Down is held#689ddrcoder wants to merge 2 commits into
ddrcoder wants to merge 2 commits into
Conversation
The bare `.collect()` calls left the background/foreground scratch types as inference variables when `.chain(&...)` needed `&_: IntoIterator`, and the trait solver recursed into objc2's `&Retained<T>: IntoIterator` blanket impl until it hit the recursion limit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Editing FSR thresholds on the Configure Pads screen took one press per step, so a big change meant hammering the key. Holding Up/Down now keeps stepping the focused value after a short delay, and the repeat rate accelerates the longer the key is held, so both a few-unit nudge and a full sweep of the range are comfortable. Applies to the Simple threshold cursor and the Advanced per-sensor / debounce focus, on the standalone screen and the Song Select overlay. Releasing the key, pressing any other control, or leaving the edit view (save box, profiles list) ends the repeat. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editing FSR thresholds on the Configure Pads screen took one press per step, so a big change meant hammering Up/Down. Holding the key now keeps stepping the focused value: nothing happens during a short initial delay (0.35 s), then repeats start at 140 ms and each one shortens the next by 12 % down to a 30 ms floor — a few-unit nudge and a full sweep of the range are both comfortable.
pad_config::update).step_focused_value, so a hold does exactly what N presses would (same fine/coarse step, same clamps, same one-command-per-target queueing).Stacked on #686 (the macOS-only E0275 fix on
main), so this branch includes that commit too; merge #686 first and this collapses to the single feature commit. Independent of #690 (0tares the focused threshold) — same file, different functions.Test plan
cargo test -p deadsync-theme-simply-love --lib -- pad_config::tests— new: repeats only after the delay and accelerate across equal windows, release stops them, another control cancels the hold, Advanced focus repeats with the press stepcargo buildon macOSDEADSYNC_MOCK_PADS=loadcell,fsr: hold Up/Down on Simple and Advanced, on the Options screen and the Song Select overlay🤖 Generated with Claude Code