fix(python): log malformed hosted response bodies at debug - #1805
Open
ThomasHartDev wants to merge 1 commit into
Open
fix(python): log malformed hosted response bodies at debug#1805ThomasHartDev wants to merge 1 commit into
ThomasHartDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1792
_json_payloadinsdks/python/pmxt/_hosted_errors.pyswallowed aValueErrorfromresponse.json()and returnedNonewith no logging. When the hosted trading API returned a non-JSON or malformed body, the resultingHostedTradingErrorlost all detail about the raw response, which makes backend contract changes and malformed error responses harder to diagnose.This adds a module logger and a
logger.debugline in the except path so the parse failure is recorded before falling back toNone. Behavior is otherwise unchanged: the function still returnsNoneand the error mapping flow is untouched.I used
%s-style logging to match the stdlib logging already used in the SDK (ws_client.py) rather than the dict-arg form in the issue, since that form doesn't fit stdlib%formatting.Added a test in
tests/test_hosted_errors.pythat drives a malformed 5xx body throughraise_from_responseand asserts the debug record is emitted while theHostedTradingErrorstill raises. Verified locally: the fulltest_hosted_errors.pysuite passes (29 tests), and the new test fails without the log line.