Potential fix for code scanning alert no. 4: Log entries created from user input#32
Merged
Potential fix for code scanning alert no. 4: Log entries created from user input#32
Conversation
… user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/plexusone/agentkit/security/code-scanning/4
In general, the fix is to sanitize or encode user-provided values before logging them so that they cannot inject new log entries or otherwise break log structure. For plain-text logs, the minimal protection is to strip newline (
\n) and carriage return (\r) characters from user-controlled strings prior to logging.For this specific case, we want to keep the existing logging behavior (still log the session ID) but ensure that
req.SessionIDcannot inject extra lines. The best minimally invasive fix is to create a local sanitized copy ofreq.SessionIDinsidehandleInvocationsright before it is logged, replacing\nand\rwith empty strings using the standardstringspackage, and log that sanitized value instead. We need to add an import of"strings"toplatforms/agentcore/server.goto support this, without changing existing imports otherwise.Concretely:
platforms/agentcore/server.go, update the import block to includestrings.handleInvocations, just before or inside the log statement at lines 133–135, create a variable likesafeSessionID := strings.ReplaceAll(strings.ReplaceAll(req.SessionID, "\n", ""), "\r", "")and then passsafeSessionIDtolog.Printfinstead ofreq.SessionID.No other behavior or control flow needs to change.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.